Handled Surface API review comments #6224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
force-pushed
the
joviegas/post-surface-api-review
branch
from
7b08f1d to
1b1caa0
Compare
Fred1155
reviewed
Jul 1, 2025
...oftware/amazon/awssdk/http/apache5/Apache5HttpClientLocalAddressOnBuilderFunctionalTest.java
Outdated
Show resolved
Hide resolved
|
Fred1155
approved these changes
Jul 3, 2025
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled Surface API review comments
Motivation and Context
This change adds support for configuring a local address in the Apache5 HTTP client, bringing it to feature parity with the Apache HTTP client.
Modifications
Added local address configuration to Apache5HttpClient:
localAddressfield to theDefaultBuilderclasslocalAddress(InetAddress)method to theBuilderinterfacesetLocalAddress(InetAddress)for bean-style configurationaddProxyConfig()to handle local address configuration when no custom route planner is providedUpdated client name:
CLIENT_NAMEfrom "Apache5" to "Apache5Preview" to identify Preview in user agentsAdded test coverage:
Apache5HttpClientLocalAddressOnBuilderFunctionalTestto test local address configuration via builderApache5HttpClientLocalAddressRoutePlannerFunctionalTestfor clarityMetricReportingTestto expect the new client namePackage name consistency:
.brazil.jsonto use consistent casing:AwsJavaSdk-HttpClient-Apache5Client-PreviewTesting
License